-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix movement bugs that break integration tests #32
base: experimental
Are you sure you want to change the base?
Fix movement bugs that break integration tests #32
Conversation
No, no, apparently another test is failing now. |
|
Try re-running checks. I had that problem and when I re-ran the checks there was no more trouble. |
I apparently do not have the brain power to follow this today. Will try again later. But I'd like to get this and your other PR tested and merged in the very near future. |
It is a sporadic failure; about one in three times, it'll fail. Presently, github says it has failed, and doesn't give any logs. I think we can safely say the fix doesn't work. That's probably why I changed it to a draft. |
I'm hoping that <24h I will have the brain power to analyze this, resolve the conflicts, test, and see how things go. No guarantees, though. |
I haven't seen an integration test fail in the last month or two; unless those wouldn't show up in PR checks. Would they? If a failing integration test would show up as a failed check, then I think we can close this as it hasn't happened in a while. |
Bugfix: Fixes #29 and some related problems mentioned on Discord
Fix Details
Testing Done
Ran the integration tests. Flew around a bit.
I ran the failing integration test ten times on an Ubuntu 22 GL build, and it passed.