Skip to content

Relax some linter checks for StoryQuests #1227

@wjt

Description

@wjt

We have configured the various linters (licensing, formatting, code style) to not run as GitHub Actions in forks, but when people come to submit their work to us (or if they set up pre-commit locally) the checks run.

As seen on #946 / https://github.com/endlessm/threadbare/actions/runs/17930321063/job/51020963668?pr=946 it is common for a large number of checks to fail at this point.

We could consider relaxing some of these checks to, e.g., not apply gdlint to .gd files in StoryQuests. The reason I added linting to the project as a whole is that this game doubles as a learning tool and I think the code in the project should be consistent and high-quality. Of course linting doesn't guarantee high-quality code but in my experience it helps (and avoids discussions about how to format code). But code in a StoryQuest (rather than in the main project) may be less likely to be treated as an example by other contributors in future.

Before doing that, though, I would like to see whether we can improve the checks to make it easy to comply.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions