The ses-shim tests on Node 12 despite our min support being Node 18 #2418
Assignees
Labels
bug
Something isn't working
Comments
|
The Node 12 dependency comes from @kriskowal 's #1308 , which upgraded it from Node 10 to Node 12. @kriskowal can we just upgrade this again to 18 and call it a day? Since you authored #1308 , can I assign to you? |
|
Experiment at #2419 |
erights
added a commit
that referenced
this issue
Sep 4, 2024
Staged on #2419 Closes: #XXXX Refs: #2414 #2418 #2419 ## Description #2414 by itself does not work on Node 18 and Node 20 because - those platforms do not have `Array.prototype.transfer`, so #2414 must use `structuredClone` instead - `structuredClone` does exist on Node >= 18, so it should be on supported platforms (though see #2418 ). However, `structuredClone` itself is dangerous and so must not be added to the shared intrinsics. As a result, in #2414 , when `@endo/pass-style` is initialized in a created compartment, it fails to find either `Array.prototype.transfer` and `structuredClone To solve this, @kriskowal suggested that we also shim `Array.prototype.transfer` if needed during `lockdown`, along with other repairs. We are avoiding similarly shimming `Array.prototype.transferToImmutable` because it is not yet standard. But `Array.prototype.transfer` is standard, and so `lockdown` can globally shim it before hardening the shared intrinsics. This PR implements @kriskowal 's suggestion. ### Security Considerations none ### Scaling Considerations by itself, none ### Documentation Considerations nothing signicant. ### Testing Considerations See #2418 . Aside from that, none ### Compatibility and Upgrade Considerations On platforms with neither `Array.prototype.transfer` nor a global `structuredClone`, the ses-shim will *currently* not install an emulation of `Array.prototype.transfer`. However, once we verify that endo is not intended to support platforms without both, we may change lockdown to throw, failing to lock down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#2417 as of this writing fails both "platform-compatibility-test"s, allegedly for Node 18 and Node 20. However, these tests also depend on Node 12, which #2417 does not support.
The culprit seems to be
endo/.github/workflows/ci.yml
Lines 273 to 276 in 46ca503
where the Node v12 dependency seems to be intentional.
The text was updated successfully, but these errors were encountered: