Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we rename this folder ./lib/tide/ to /lib/data-services/ ? #14

Open
giorgioriccardi opened this issue Feb 11, 2021 · 2 comments
Open

should we rename this folder ./lib/tide/ to /lib/data-services/ ? #14

giorgioriccardi opened this issue Feb 11, 2021 · 2 comments
Assignees
@giorgioriccardi
Labels
question Further information is requested

Comments

@giorgioriccardi
Copy link
Collaborator

bowen.today/lib/weather/tide.php

Line 1 in f6dbeb0

<?php

I did not check why it's there, but shouldn't we separate ./lib/tide and ./lib/weather ?
@giorgioriccardi giorgioriccardi changed the title should we move this tide.php into its folder ./lib/tide/tide.php ? should we rename this folder ./lib/tide/ to /lib/data-services/ ? Feb 11, 2021
@giorgioriccardi giorgioriccardi added the question Further information is requested label Feb 11, 2021
@giorgioriccardi giorgioriccardi self-assigned this Feb 11, 2021
@giorgioriccardi
Copy link
Collaborator Author

Following our conversation maybe the weather folder could become /lib/data-services/ just an idea... @enejb

@enejb
Copy link
Owner

enejb commented Feb 13, 2021

I think that would probably be a good way to organize things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giorgioriccardi giorgioriccardi

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enejb @giorgioriccardi