New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG - ERC1888 array overrun #3365

Open

Jon-Salmon opened this issue Sep 21, 2022 · 0 comments

Jon-Salmon commented Sep 21, 2022 •

edited

Loading

The batchIssue function appears to have a bug where the for loop is bounded incorrectly resulting in an array overflow.

origin/packages/traceability/issuer/contracts/Registry.sol

Line 53 in 4048d1b

ids = new uint256[](_values.length);

origin/packages/traceability/issuer/contracts/Registry.sol

Lines 57 to 58 in 4048d1b

    
           for (uint256 i = 0; i <= _values.length; i++) { 
        
           	ids[i] = i + _latestCertificateId + 1;

Jon-Salmon changed the title ~~BUG - ERC1188 array overrun~~ BUG - ERC1888 array overrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment