Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add View Button Misaligned #125

Open
rickmcgeer opened this issue Dec 9, 2022 · 1 comment
Open

Add View Button Misaligned #125

rickmcgeer opened this issue Dec 9, 2022 · 1 comment
Assignees
Labels
bug Something isn't working review fixed, ready for review

Comments

@rickmcgeer
Copy link
Contributor

add-view-misaligned

@rickmcgeer rickmcgeer self-assigned this Dec 9, 2022
@rickmcgeer
Copy link
Contributor Author

Now fixed, but I would like @merryman to comment. Two questions:

  1. I fixed this by adding a layout to the add button on view control (details below) but none of the other buttons have a layout and they are fine. Is this the right fix and should it be done for the other buttons?
  2. You can see that the button has both a label and an icon, but I don't see the icon in either the label or as a submorph of button. Where is it?

Code added:

            axis: 'row',
            align: 'center',
            axisAlign: 'center'
          }),

to the view submorph of ControlPanel. See:
$world.execCommand("open browser", {moduleName: "studio/side-bar.cp.js", packageName: "galyleo-dashboard", });

add-view-fixed

@rickmcgeer rickmcgeer added bug Something isn't working review fixed, ready for review labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review fixed, ready for review
Projects
None yet
Development

No branches or pull requests

2 participants