Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We aren't showing RangeFilter in the filters dropdown #131

Open
rickmcgeer opened this issue Dec 10, 2022 · 2 comments
Open

We aren't showing RangeFilter in the filters dropdown #131

rickmcgeer opened this issue Dec 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working review fixed, ready for review

Comments

@rickmcgeer
Copy link
Contributor

No description provided.

@rickmcgeer rickmcgeer self-assigned this Dec 10, 2022
@rickmcgeer rickmcgeer changed the title We aren't showing RangeFilter in the filters dropdoen We aren't showing RangeFilter in the filters dropdown Dec 12, 2022
@rickmcgeer rickmcgeer added bug Something isn't working review fixed, ready for review labels Dec 13, 2022
@rickmcgeer
Copy link
Contributor Author

Now showing as minMax Filter, added to get filterTypes() in FilterBuilder. Assigning to @merryman for review.

$world.execCommand("open browser", {moduleName: "studio/filter-creator.cp.js", packageName: "galyleo-dashboard", codeEntity: "FilterBuilder"});

@rickmcgeer rickmcgeer removed the review fixed, ready for review label Dec 15, 2022
@rickmcgeer
Copy link
Contributor Author

I added an ensureWithinBounds method to RangeFilter. See

$world.execCommand("open browser", {moduleName: "studio/filters.cp.js", packageName: "galyleo-dashboard", });

However, it appears it's not getting called. It's waiting for a numberChanged signal from NumberWidget and it doesn't appear that NumberWidget generates such a signal.

$world.execCommand("open browser", {moduleName: "value-widgets.js", packageName: "lively.ide", codeEntity: "NumberWidget"});

@merryman can you tell me how to check for a NumberWidget entry change?

@rickmcgeer rickmcgeer added the review fixed, ready for review label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review fixed, ready for review
Projects
None yet
Development

No branches or pull requests

2 participants