Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a ChartJS module and implementation #140

Open
rickmcgeer opened this issue Jan 9, 2023 · 1 comment
Open

Need a ChartJS module and implementation #140

rickmcgeer opened this issue Jan 9, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request review fixed, ready for review

Comments

@rickmcgeer
Copy link
Contributor

Per the discussion in #139, we need to implement a ChartJS chart module which implements the Visualization API, and an associated editor.

@rickmcgeer rickmcgeer added enhancement New feature or request review fixed, ready for review labels Jan 9, 2023
@rickmcgeer
Copy link
Contributor Author

There is now a preliminary implementation in 6564f4a.
See

$world.execCommand("open browser", {moduleName: "studio/chart-creator.cp.js", packageName: "galyleo-dashboard", });

The new classes are ChartDiagramModel, ChartDiagram, which implement the ViewModel and View of the ChartJS chart, and ChartJSEditorModel and ChartJSEditor, which implement the ViewModel and View of the ChartJS Editor

This (in particular, the editor parts) are very preliminary and have been done without a perfect understanding of the Lively UI elements, so a discussion and review are welcome. @merryman please look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review fixed, ready for review
Projects
None yet
Development

No branches or pull requests

2 participants