Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a dashboard fails to load, the publication dashboard should prompt for a new URL #148

Open
rickmcgeer opened this issue Jan 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@rickmcgeer
Copy link
Contributor

We had this built in, but it's essentially defunct.

@rickmcgeer rickmcgeer added the enhancement New feature or request label Jan 18, 2023
@rickmcgeer rickmcgeer self-assigned this Jan 18, 2023
@rickmcgeer
Copy link
Contributor Author

Now revived, but there are issues

In PublishedDashboard.init(), the following code is now added:

  if (url) {
      const valid = await this.loadDashboardFromURL(url);
      if (!valid) {
        this._initURLPrompt_(url);
      }
    } else {
      this._initURLPrompt_(null);
    }

And _initUrlPrompt_ is:

_initURLPrompt_ (url, message) {
    if (message) {
      $world.inform(message);
    }
    const loadDialog = part(LoadDialog);
    loadDialog.init(this, url);
    loadDialog.openInWorld();
  }

See:

$world.execCommand("open browser", {moduleName: "publication/dashboard.js", packageName: "galyleo-dashboard", });

LoadDialog and LoadDialogMorph are in dashboard.cp.js, but the bindings to the button events seem non-functional. @merryman, can you take a look?

$world.execCommand("open browser", {moduleName: "studio/dashboard.cp.js", packageName: "galyleo-dashboard", codeEntity: "LoadDialog"});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants