Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to be much more robust about the google chart packages getting loaded #149

Open
rickmcgeer opened this issue Jan 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rickmcgeer
Copy link
Contributor

There are timing issues here -- errors are thrown when we attempt to draw a Google chart before the visualization libraries are loaded. This needs to (a) be checked; and (b) ensure that the gViz libraries are loaded in an await block.

@rickmcgeer rickmcgeer added the bug Something isn't working label Jan 18, 2023
@rickmcgeer rickmcgeer self-assigned this Jan 18, 2023
@rickmcgeer
Copy link
Contributor Author

Added if (!this.gViz) return; to DashboardCommon.drawChart
See:

$world.execCommand("open browser", {moduleName: "studio/dashboard-common.cp.js", packageName: "galyleo-dashboard", codeEntity: [{"name":"DashboardCommon","type":"class-decl"},{"name":"drawChart","type":"class-instance-method"}]});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant