Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The display is not working correctly with the filter I created. #197

Open
Shima-Nao opened this issue Jun 10, 2024 · 7 comments
Open

The display is not working correctly with the filter I created. #197

Shima-Nao opened this issue Jun 10, 2024 · 7 comments

Comments

@Shima-Nao
Copy link

Shima-Nao commented Jun 10, 2024

@rickmcgeer @merryman @mhemmings-engage
*Please refer to the video.
It seems the slider in the filter is not working properly.
For example, the Year remains a fixed value.

20240610_01mini01.mp4
@rickmcgeer
Copy link
Contributor

This is a bug in the remote_tables code, which has been fixed on my development system. It will be completely revised once the SDTP/Data Plane is released, which will happen this week.

@Shima-Nao
Copy link
Author

Shima-Nao commented Jul 1, 2024

@rickmcgeer @merryman

  1. The dialog cannot be closed even if the button is pressed.
  2. Bug report not fixed yet.

*Other issues seem to have been fixed.

20240701_01.mp4

image

@rickmcgeer
Copy link
Contributor

I have fixed this locally and I'm deploying tonight

@rickmcgeer
Copy link
Contributor

this should now be fixed, @Shima-Nao . Please confirm

@Shima-Nao
Copy link
Author

Shima-Nao commented Jul 2, 2024

this should now be fixed, @Shima-Nao . Please confirm

@rickmcgeer
I have confirmed that the view control is properly disappearing. Thank you for addressing this.

  1. The dialog cannot be closed even if the button is pressed.

I have one thing to confirm. The column selection of this view control can no longer be moved to the top priority. (If I remember correctly, the X-axis was designed to be moved to the top). Currently, the selected column moves to the top after committing the selection and reopening it. Has the specification been changed?

image

  1. Bug report not fixed yet.

The bug report still seems to be unresolved. It's not critical, so it doesn't need to be rushed, but please fix it as soon as possible.

@rickmcgeer
Copy link
Contributor

rickmcgeer commented Jul 2, 2024

@Shima-Nao

  • The columns are moved after you select order mode with the pen icon at the top right
    image
    This is the icon:
    image
    The boxes on the left turn into "burgers" (three bars):
    image
    The pointer icon changes to a hand and the order can be changed:
    image
    Let me know if this doesn't work for you

And the order is only relevant for selected columns -- unselected columns aren't relevant. The column order in the two images you showed are functionally equivalent, since the "Year" and "State" columns won't be forwarded to the chart.

Clicking the pen icon again goes back to select/deselect view
image

@Shima-Nao
Copy link
Author

Shima-Nao commented Jul 2, 2024

@rickmcgeer Thank you for telling. googd works it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants