Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-uri breaks ES5 support #156

Open
stereopasa opened this issue Feb 8, 2022 · 1 comment
Open

parse-uri breaks ES5 support #156

stereopasa opened this issue Feb 8, 2022 · 1 comment

Comments

@stereopasa
Copy link

heya guys

just noticed that library dependency https://github.com/Kikobeats/parse-uri was upgraded and uses Arrow function expressions syntax now (v1.0.5), which breaks ES5 support (for version v2 and v3, which is used by pixijs@4 and pixijs@5)

don't know about correct way of fixing that: pinning the version here or asking them to fix theirs build

@englercj
Copy link
Owner

englercj commented Feb 9, 2022

Unfortunate they would make a breaking change like that in a patch version.

Pinning the version here would help, but only if we release a new version here with the pin and then a new version of pixi using it. Alternatively you can pin the version in your project directly which will fix the issue for you immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants