More info in CloseCode.SubprotocolNotAcceptable situations?

[theogravity]

We've been seeing this in our error logs, but we're not sure what the source is. We have converted all the stuff we know of to Apollo 3 / graphql-ws. There could be some chance someone is using something with an older client, but it's hard to tell because our error logs only print this message:

WebSocket protocol error occured. It was most likely caused due to an unsupported subprotocol "" requested by the client. graphql-ws implements exclusively the "graphql-transport-ws" subprotocol, please make sure that the client implements it too.

Is there a way for us to try / catch somewhere on the server-side so we can add context in? We're using Apollo Express + ws.

[enisdenjo]

Some of your clients are trying to connect without specifying a subprotocol, while the required subprotocol is "graphql-transport-ws".

I've added that log so that people transitioning from subscriptions-transport-ws are aware that this lib is not cross-compatible. Maybe I should console log exclusively if the deprecated subprotocol is detected? Starting from v5.6.4, server integrations warn only when detecting subscriptions-transport-ws clients.

The log comes from here and can be disabled by running the server in production mode (export NODE_ENV=production).

[theogravity]

Some of your clients are trying to connect without specifying a subprotocol, while the required subprotocol is "graphql-transport-ws".

I've added that log so that people transitioning from subscriptions-transport-ws are aware that this lib is not cross-compatible. Maybe I should console log exclusively if the deprecated subprotocol is detected? 🤔

The log comes from here, you can disable it by running the server in production mode (export NODE_ENV=production).

I think what's curious is that the subprotocol in the log doesn't specify a subprotocol at all. We were using the old transport lib for our apollo 2 stuff, not sure if that included the graphql-ws subprotocol marker.

[enisdenjo]

I think what's curious is that the subprotocol in the log doesn't specify a subprotocol at all.

That is a client-side issue unrelated to graphql-ws.

Furthermore, starting from v5.6.4, server integrations warn only when detecting subscriptions-transport-ws clients.