Unexpected retry behavior

[paymog]

Screenshot

Client initialization:

const wsLink = new GraphQLWsLink(
  // https://stackoverflow.com/a/60958527/1489726
  process.browser
    ? createClient({
        url: settings?.graphql?.wsUri,
        retryAttempts: 10,
        retryWait: async (retries) => {
          console.log(`retry attempt #${retries}`);

          // taken directly from the docs at https://github.com/enisdenjo/graphql-ws#retry-strategy
          // after the server becomes ready, wait for a second + random 1-4s timeout
          // (avoid DDoSing yourself) and try connecting again
          await new Promise((resolve) => setTimeout(resolve, 1000 + Math.random() * 3000));
        },
      })
    : null,
);

Expected Behaviour
I expect multiple retry attempts to happen and multiple log lines of the form retry attempt #... to be printed in the browser

Actual Behaviour
It seems only 1 retry attempt is attempted because I only see 1 log line

Debug Information

1. start up apollo server
2. start up app with the above websocket client
3. see the webscoket is connected
4. stop apollo server
5. see that only 1 retry attempt is made

Further Information
Is it possible that a server that's down is considered a fatal error? If so, are there docs which explain that? It's not obvious if a non-responsive server is fatal based on the comments in createClient

graphql-ws/src/client.ts

Lines 328 to 337 in e9f7c94

	* The library classifies the following close events as fatal:
	* - _All internal WebSocket fatal close codes (check `isFatalInternalCloseCode` in `src/client.ts` for exact list)_
	* - `4500: Internal server error`
	* - `4005: Internal client error`
	* - `4400: Bad request`
	* - `4004: Bad response`
	* - `4401: Unauthorized` _tried subscribing before connect ack_
	* - `4406: Subprotocol not acceptable`
	* - `4409: Subscriber for <id> already exists` _distinction is very important_
	* - `4429: Too many initialisation requests`

[enisdenjo]

All non-close-event connection problems are considered fatal by default. Your client seems to be throwing undefined, which is not a WebSocket CloseEvent.

If you want the client to retry regardless, you can implement your own shouldRetry option and have it return true always (or with pre v5.8.0 the now deprecated isFatalConnectionProblem option and return false always).