extra.socket.protocol set to '' (empty string) in onClose event listener, for closure that do not connect due to deprecated sub-protocol

[loucadufault]

I have noticed for Server, with clients that attempt to connect with Sec-WebSocket-Protocol header set to the old graphql-ws, when logging the extra.socket.protocol received by the onClose listener, it is an empty string. However, logging the req.headers['sec-websocket-protocol'] shows the populated value.

Is this something that is expected? I would prefer to not have to cover both cases in the handling logic.

[enisdenjo]

Hey hey, this is unrelated to graphql-ws itself. The extra.socket is Node's ws socket instance (when using graphql-ws/lib/use/ws).

Briefly going through their code, the socket.protocol is set here, could be that the connection fails earlier?