Merge pull request #944 from enketo/fix/date-month-year-autocomplete-943

Fix: undesired autocompletion of manually entered incomplete month-ye…
enketo · Feb 1, 2023 · 885dde9 · 885dde9
2 parents fafb623 + 854efaf
commit 885dde9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/widget/date/datepicker-extended.js b/src/widget/date/datepicker-extended.js
@@ -92,12 +92,12 @@ class DatepickerExtended extends Widget {
             let value =
                 e.type === 'paste'
                     ? getPasteData(e.originalEvent ?? e)
-                    : this.value;
+                    : this.displayedValue;
 
             if (value.length > 0) {
                 // Note: types.date.convert considers numbers to be a number of days since the epoch
                 // as this is what the XPath evaluator may return.
-                // For user-entered input, we want to consider a Number value to be incorrect, expect for year input.
+                // For user-entered input, we want to consider a Number value to be incorrect, except for year input.
                 if (isNumber(value) && settings.format !== 'yyyy') {
                     convertedValue = '';
                 } else {

diff --git a/test/spec/widget.date.spec.js b/test/spec/widget.date.spec.js
@@ -96,6 +96,17 @@ describe('datepicker widget', () => {
 
                 fakeInput.dispatchEvent(event);
 
+                expect(input.value).to.equal('');
+            });
+            it(`sets empty string when user enters year and appearance is ${desc}`, () => {
+                const input = initForm(form).element;
+                const fakeInput = input
+                    .closest('.question')
+                    .querySelector('.widget input');
+
+                fakeInput.value = '2012';
+                fakeInput.dispatchEvent(new Event('change'));
+
                 expect(input.value).to.equal('');
             });
         });