Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show who's change broke the build #10

Open
sjincho opened this issue Sep 14, 2015 · 8 comments
Open

Feature request: Show who's change broke the build #10

sjincho opened this issue Sep 14, 2015 · 8 comments

Comments

@sjincho
Copy link

sjincho commented Sep 14, 2015

It would be great if the plugin could show the authors of the changes in the slack message.

@luketheobscure
Copy link

+1

@cy6erskunk
Copy link
Contributor

What if there're 100 commits from 50 authors?

@irobinson
Copy link
Contributor

@cy6erskunk Perhaps we could pull out the list of authors & just truncate the string after a maximum number of characters if that's a concern. I would have to imagine that we could come up with a comfortable maximum such that it would be concise and useful in most circumstances but still usable in those edge cases.

@zilionis
Copy link

+1
Maybe should show last committer
Also would be great to have custom config to show branch name :)

@zilionis
Copy link

Btw, i just updated plugin with that new icons. I saw branch show issue was fixed, but in mine report branch name still missing
(I changed output to be more readable :) )

✅ PROJECT_NAME #68 built successfully
Build Status

Project: PROJECT_NAME
Build: 68
Status: built successfully

@cy6erskunk
Copy link
Contributor

@zilionis Default branch name is not displayed in the notifications, maybe it is your case?
And why do you need custom config to show branch name, what problem is should solve?

@zilionis
Copy link

@cy6erskunk if we have notification in slack with all different branches is nice to see branch (we will use multiple of them) and who broke it :). Just want same message in all cases.

@DotNetRockStar
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants