Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Library for Posting to Slack #34

Open
eljobe opened this issue Sep 21, 2016 · 1 comment
Open

Use Library for Posting to Slack #34

eljobe opened this issue Sep 21, 2016 · 1 comment

Comments

@eljobe
Copy link
Contributor

eljobe commented Sep 21, 2016

There's a java library slack-webhook

Which does a lot of the same work our SlackPayload and SlackWrapper classes are currently doing. The SlackPayload is a little problematic right now because it really mixes the responsibilities of representing a Slack message with the responsibility of how to construct that message from the TeamCity data. In looking at a way to separate those responsibilities, I stumbled upon this library which I think could simplify this plugin.

Would you be open to a pull request which switches to using it?

@eljobe
Copy link
Contributor Author

eljobe commented Sep 23, 2016

I'm going to take the ❤️ reaction from @cy6erskunk as a "greenlight" on implementing this. You can assign the issue to me if you do that sort of bookkeeping on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant