-
Notifications
You must be signed in to change notification settings - Fork 13
chore: Test 'bazel vendor' Nix outputHash stability (re. #1875) #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Nix derivation aimed at rigorously testing the stability and reproducibility of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Nix derivation to test the output hash stability of bazel vendor, which is a good step towards more reproducible builds. My review includes a critical fix for a likely permission error that is mentioned in the pull request description, which should allow the build to succeed in the sandboxed Nix environment. I've also added a minor suggestion to improve the build log's clarity.
c6994b3 to
7a4dfc0
Compare
|
Given #1875 (comment), I'm closing this PR, as a "failed experiment". #1878 picks up the |
This is a sub-set of #1873,
which we could try to get into a mergeable state sooner rather than later,
because it would allow to observe #1875 in practive - letting us see if
vendoroutput is stable enough to e.g. run on GitHub Actions environment.This PR currently fails for me locally due to
Permission denied#1876; I'm curious to see if it passes on CI.@dotdoom shout if you know how to fix that (permission) for this PR? Then I would merge this, and we could see how stable it really is.