From 66d1b20a6fd009a7a366cdd151dfecd6745fb2ee Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Mon, 27 May 2024 13:41:43 +0200 Subject: [PATCH] Fix "Test is missing assertions" warnings Rails Edge produced some warnings: - Test is missing assertions: `test_action_controller_gets_locale_setter` - Test is missing assertions: `test_action_controller_gets_locale_suffix_helper` - Test is missing assertions: `test_action_view_gets_locale_suffix_helper` Those tests never worked because the assertion was missing (they were returning false) and broke at a certain point in time --- test/routing_test.rb | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/test/routing_test.rb b/test/routing_test.rb index 9ea987f0..421b7081 100644 --- a/test/routing_test.rb +++ b/test/routing_test.rb @@ -620,15 +620,7 @@ def test_host_locales end def test_action_controller_gets_locale_setter - ActionController::Base.instance_methods.include?('set_locale_from_url') - end - - def test_action_controller_gets_locale_suffix_helper - ActionController::Base.instance_methods.include?('locale_suffix') - end - - def test_action_view_gets_locale_suffix_helper - ActionView::Base.instance_methods.include?('locale_suffix') + assert_includes ActionController::Base.private_instance_methods, :set_locale_from_url end # See https://github.com/enriclluelles/route_translator/issues/69