Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Editor Panel Open/Close button #10386

Closed
AdRiley opened this issue Jun 27, 2024 · 0 comments · Fixed by #10413
Closed

Add Code Editor Panel Open/Close button #10386

AdRiley opened this issue Jun 27, 2024 · 0 comments · Fixed by #10413
Assignees
@kazcw
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
2024-07 Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Jun 27, 2024 •
edited
Loading

Add new button bottom left to toggle open/close of code editor

icon: bottom_panel

Closed

image

Open

image

Doc panel and code panel open

image

Notes:

  • Screenshots for concept only. Sizing/spacing to be determined by implementor
  • Add component button moves bottom right and moves in when code panel or doc panel opened
  • Red cross for close should go
  • Maybe left gutter could be wider
  • Button up/down should match the doc panel up/down coloring
  • Code editor is now fixed width across bottom of screen.
  • When doc panel open. Code editor shrinks.
  • Resize handle can go.
  • Entire top edge should allow vertical resizing
  • Entire top edge should have vertical resize cursor
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Jun 27, 2024
@AdRiley AdRiley added this to the 2024-07 Release milestone Jun 27, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Jun 27, 2024
@kazcw kazcw self-assigned this Jun 27, 2024
@enso-bot enso-bot bot mentioned this issue Jun 28, 2024
Closed
@kazcw kazcw mentioned this issue Jul 4, 2024
Merged
4 tasks
@kazcw kazcw linked a pull request Jul 4, 2024 that will close this issue
Doc editor and code editor are toggleable docks #10413
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Jul 4, 2024
@kazcw
Doc editor and code editor are toggleable docks (#10413)
d46e4ac 
Dock improvements:
- Right and bottom docks are toggled with buttons.
- Bottom dock:
- Fills available width.
- Height resize handle behaves like right dock's.
- Documentation editor: Top toolbar is outside scrollable area.
- Extended menu: Entries have icons.
- Add component button: Now in bottom-right.

https://github.com/enso-org/enso/assets/1047859/19d64fed-74ab-48c2-af0e-48f140fa8474

Closes #10385, #10386.

# Important Notes
- `unrefElement`: Fixed a type-safety bug in; documented a reactivity limitation.
- `keyboardBusy`: Fixed a bug where shortcuts were ignored after clicking any button.
- Fixed right-dock slide-in animation.
@mergify mergify bot closed this as completed in #10413 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Status: 🗄️ Archived
Milestone
2024-07 Release
Development

Successfully merging a pull request may close this issue.

Doc editor and code editor are toggleable docks enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon