Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imageRef field in volatileConfig #1745

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Jul 4, 2024

Allows restricting the include/exclude configuration to particular image via imageRef field in volatileConfig.

Reference: EC-631

Allows restricting the include/exclude configuration to particular image
via `imageRef` field in `volatileConfig`.

Reference: EC-631
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (e1cc4f5) to head (ffb8fdf).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
+ Coverage   80.35%   87.15%   +6.79%     
==========================================
  Files          67       79      +12     
  Lines        4886     5261     +375     
==========================================
+ Hits         3926     4585     +659     
+ Misses        960      676     -284     
Flag Coverage Δ
acceptance 72.42% <89.74%> (?)
generative 80.76% <94.87%> (+0.41%) ⬆️
integration 80.76% <94.87%> (+0.41%) ⬆️
unit 80.76% <94.87%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/definition/validate.go 83.92% <100.00%> (ø)
internal/evaluator/conftest_evaluator.go 87.50% <100.00%> (+2.51%) ⬆️
internal/input/validate.go 84.21% <100.00%> (ø)
internal/image/validate.go 73.87% <83.33%> (+1.23%) ⬆️
internal/evaluator/criteria.go 94.91% <94.91%> (ø)

... and 39 files with indirect coverage changes

@joejstuart joejstuart merged commit 6e2bf5f into enterprise-contract:main Jul 4, 2024
9 of 10 checks passed
@zregvart zregvart deleted the pr/EC-631 branch September 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants