Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate future_required_tasks_found and required_tasks_found #1026

Open
lcarva opened this issue Jun 5, 2024 · 0 comments
Open

Consolidate future_required_tasks_found and required_tasks_found #1026

lcarva opened this issue Jun 5, 2024 · 0 comments

Comments

@lcarva
Copy link
Member

lcarva commented Jun 5, 2024

We have these policy rules:

  • future_required_tasks_found: emits a warning if a required Task is missing but the rule data says that it is only required in the future.
  • required_tasks_found: emits a violation if a required Task is missing and the rule data does not specify that this is required in the future.

The two policy rules are closely tied. When a user wants to include/exclude these policy rules, they must specify both. This is confusing.

Let's consolidate both of these policy rules into a single one. We can emit a dynamic effective_on date in the result for required Tasks in the future. This would be similar to what we did here for the labels package.

Acceptance Criteria

  • future_required_tasks_found is handled as part of required_tasks_found. This is done in both release and pipeline namespaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant