Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop depending on BASE_IMAGES_DIGESTS TaskRun result #1155

Closed
zregvart opened this issue Sep 26, 2024 · 1 comment · Fixed by #1170
Closed

Stop depending on BASE_IMAGES_DIGESTS TaskRun result #1155

zregvart opened this issue Sep 26, 2024 · 1 comment · Fixed by #1170

Comments

@zregvart
Copy link
Member

The BASE_IMAGES_DIGESTS TaskRun result will be deprecated and removed.

We have the base_image_registries.base_image_info_found rule that checks that the BASE_IMAGES_DIGESTS TaskRun result is provided, we most likely need to remove that part of the rule and adjust the documentation. As well as fetching the base image information via that result.

@lcarva
Copy link
Member

lcarva commented Sep 26, 2024

We should definitely do that for clean up purposes. 👍

I just want to clarify that all the rules in that package should handle the case where that result is not specified. base_image_registries.base_image_info_found for example will only emit a violation if the result is not found and no sboms were also found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants