Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations should fail #285

Open
mixmix opened this issue Nov 6, 2024 · 1 comment
Open

migrations should fail #285

mixmix opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@mixmix
Copy link
Contributor

mixmix commented Nov 6, 2024

Right now our migrations fail silently ... errors are caught and then the migrations seem to just progress D:

We need to change that behaviour to not progress the migrations if they don't run

@mixmix mixmix added this to the CLI completeness milestone Nov 12, 2024
@mixmix
Copy link
Contributor Author

mixmix commented Dec 2, 2024

Expected behaviour

If a migration throws an error:

  • the migration-version should not be progressed
  • the config should not be written
  • a helpful error should be output
  • the entropy application should NOT launch

If the user manually addresses the issue

  • the migrations should continue as normal

Examples of things which could cause throw

  • missing field/ key
  • empty config
  • ... (you think of some)

@frankiebee frankiebee modified the milestone: Function Completeness Dec 2, 2024
@mixmix mixmix self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants