Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more graceful error handling for common pathways #81

Closed
tuxxy opened this issue Jun 6, 2024 · 1 comment
Closed

Add more graceful error handling for common pathways #81

tuxxy opened this issue Jun 6, 2024 · 1 comment
Labels
Milestone

Comments

@tuxxy
Copy link

tuxxy commented Jun 6, 2024

For example, when trying to sign without registering, you get a big blob:

/Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:12218
    throw new Error(
          ^
Error: request failed 500, Internal Server Error fetch: http://3.84.209.123:3001/user/sign_tx FULLRESPONSE: Chain Fetch: Not Registering error: Register Onchain first
    at sendHttpPost (/Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:12218:11)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:12769:26
    at async Promise.all (index 1)
    at async SignatureRequestManager.sign (/Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:12670:18)
    at async SignatureRequestManager.signWithAdaptersInOrder (/Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:12636:23)
    at async Entropy.signWithAdaptersInOrder (/Users/tux/code/cli/node_modules/@entropyxyz/sdk/dist/index.cjs:13186:12)
    at async Object.sign (/Users/tux/code/cli/src/flows/sign/index.ts:91:24)
    at async main (/Users/tux/code/cli/src/index.ts:89:30)
error Command failed with exit code 1.

We should identify these common UX errors and give more graceful error messages for them rather than erroring all ugly.

@frankiebee frankiebee added the ux label Aug 20, 2024
@mixmix mixmix added this to the Usability milestone Nov 12, 2024
@mixmix
Copy link
Contributor

mixmix commented Nov 12, 2024

Here's a map of the ones I've found / we need to test:

Ones that look fine to me

  • entropy account create
  • entropy account import
  • entropy account register
  • entropy balance

closing this issue as we have spawned child issues tracking work needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants