Skip to content

Commit 6bf0d84

Browse files
authored
Merge pull request #29 from fjarri/serde-bytes
Use `serde-encoded-bytes` instead of the vendored module
2 parents 336d89f + 63570e3 commit 6bf0d84

File tree

5 files changed

+10
-56
lines changed

5 files changed

+10
-56
lines changed

manul/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ categories = ["cryptography", "no-std"]
1212

1313
[dependencies]
1414
serde = { version = "1", default-features = false, features = ["alloc", "serde_derive"] }
15+
serde-encoded-bytes = { version = "0.1", default-features = false, features = ["base64"] }
1516
digest = { version = "0.10", default-features = false }
1617
signature = { version = "2", default-features = false, features = ["digest", "rand_core"] }
1718
rand_core = { version = "0.6.4", default-features = false }

manul/src/lib.rs

-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,5 @@
1616
extern crate alloc;
1717

1818
pub mod protocol;
19-
mod serde_bytes;
2019
pub mod session;
2120
pub mod testing;

manul/src/protocol/round.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,13 @@ use core::{any::Any, fmt::Debug};
1010
use digest::Digest;
1111
use rand_core::CryptoRngCore;
1212
use serde::{Deserialize, Serialize};
13+
use serde_encoded_bytes::{Base64, SliceLike};
1314

1415
use super::{
1516
error::{LocalError, RemoteError},
1617
object_safe::{ObjectSafeRound, ObjectSafeRoundWrapper},
1718
};
18-
use crate::{
19-
serde_bytes,
20-
session::{EchoRoundError, SessionId},
21-
};
19+
use crate::session::{EchoRoundError, SessionId};
2220

2321
/// An error that can be returned from [`Round::receive_message`].
2422
#[derive(Debug)]
@@ -383,7 +381,7 @@ pub struct EchoBroadcastError(DeserializationError);
383381

384382
/// A serialized direct message.
385383
#[derive(Debug, Clone, Serialize, Deserialize)]
386-
pub struct DirectMessage(#[serde(with = "serde_bytes")] Box<[u8]>);
384+
pub struct DirectMessage(#[serde(with = "SliceLike::<Base64>")] Box<[u8]>);
387385

388386
impl DirectMessage {
389387
/// Creates a new serialized direct message.
@@ -412,7 +410,7 @@ impl DirectMessage {
412410

413411
/// A serialized echo broadcast.
414412
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
415-
pub struct EchoBroadcast(#[serde(with = "serde_bytes")] Box<[u8]>);
413+
pub struct EchoBroadcast(#[serde(with = "SliceLike::<Base64>")] Box<[u8]>);
416414

417415
impl EchoBroadcast {
418416
/// Creates a new serialized echo broadcast.

manul/src/serde_bytes.rs

-42
This file was deleted.

manul/src/session/session.rs

+5-7
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ use core::fmt::Debug;
88

99
use rand_core::CryptoRngCore;
1010
use serde::{Deserialize, Serialize};
11+
use serde_encoded_bytes::{Base64, SliceLike};
1112
use signature::{DigestVerifier, Keypair, RandomizedDigestSigner};
1213
use tracing::debug;
1314

@@ -18,17 +19,14 @@ use super::{
1819
transcript::{SessionOutcome, SessionReport, Transcript},
1920
LocalError, RemoteError,
2021
};
21-
use crate::{
22-
protocol::{
23-
Artifact, DirectMessage, EchoBroadcast, FinalizeError, FinalizeOutcome, FirstRound, ObjectSafeRound,
24-
ObjectSafeRoundWrapper, Payload, Protocol, ReceiveError, ReceiveErrorType, Round, RoundId,
25-
},
26-
serde_bytes,
22+
use crate::protocol::{
23+
Artifact, DirectMessage, EchoBroadcast, FinalizeError, FinalizeOutcome, FirstRound, ObjectSafeRound,
24+
ObjectSafeRoundWrapper, Payload, Protocol, ReceiveError, ReceiveErrorType, Round, RoundId,
2725
};
2826

2927
/// A session identifier shared between the parties.
3028
#[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq, PartialOrd, Ord, Hash)]
31-
pub struct SessionId(#[serde(with = "serde_bytes")] Box<[u8]>);
29+
pub struct SessionId(#[serde(with = "SliceLike::<Base64>")] Box<[u8]>);
3230

3331
/// A session ID.
3432
///

0 commit comments

Comments
 (0)