Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring is broken and needs more tests! #351

Open
frankiebee opened this issue May 24, 2024 · 2 comments
Open

keyring is broken and needs more tests! #351

frankiebee opened this issue May 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working keyring
Milestone

Comments

@frankiebee
Copy link
Collaborator

currently the keyring isnt respecting the admin account and it's generating new keys every time in takes in a loaded account.

this needs to be fixed

@frankiebee frankiebee added the bug Something isn't working label May 24, 2024
@frankiebee frankiebee added this to the open source/test-net milestone May 24, 2024
@frankiebee frankiebee self-assigned this May 24, 2024
@rh0delta
Copy link
Contributor

  • registration key on keyring doesn't get updated when new data is appended to the object
  • i.e verifyingKeys post registration aren't updated to the keyring, but saved in the entropy cli config

@rh0delta
Copy link
Contributor

  • on initialization of keyring, formatAccounts strips the existing data sent to the Keyring constructor

@frankiebee frankiebee changed the title keyring is broken keyring is broken and needs more tests! Jun 2, 2024
@frankiebee frankiebee removed this from the open source/test-net milestone Oct 17, 2024
@frankiebee frankiebee modified the milestones: Keyring, next version Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keyring
Projects
None yet
Development

No branches or pull requests

2 participants