Frankie/milestone#signature validation #445
Conversation
…what it is. it should be a hex encode string of the message you wish to sign
…o the signing manager
| return signatureVerify(message, signature, address).isValid | ||
| } | ||
|
|
||
| throw new Error(`unsupported hashType: ${hashType}`) |
There was a problem hiding this comment.
minor nitpick, what if we move this error handling to the above block of if-statements that throw errors if data is missing?
There was a problem hiding this comment.
this is a fair point. i worry about having functions that potentially do nothing so when in doubt throw errors. but can see if their is a nice way to move that check up some how that still results in a sensible return. ie: return: Promise<true/false>/Error
| * @returns {string} The string without the '0x' prefix. | ||
| */ | ||
|
|
||
| export function addHexPrefix (str: string): string { |
There was a problem hiding this comment.
this fn isnt just adding a hex prefix, it also checks to see if the string already is a hex string with prefix, what do you think about changing the fn name to be more descriptive like checkOrAddHexPrefix?
There was a problem hiding this comment.
checkOrAddHexPrefix seems like unnecessary verbosity
There was a problem hiding this comment.
how ever the docs are wrong 😅 so ill fix that
There was a problem hiding this comment.
i dont want to ad a 0x if one is already their that would make it invalid so i'm doing what is required of a function that would add a hex prefix with out invalidating the string
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
closes #438
closes #434
closes #442