Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes #155

Merged
merged 6 commits into from
Oct 20, 2024
Merged

Assorted fixes #155

merged 6 commits into from
Oct 20, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 19, 2024

  • Bump secrecy to the most recent stable version (0.10) (this is an internal change)
  • Bump crypto-bigint to 0.6-rc.6 and crypto-primes to 0.6.0-pre.2 (this is an internal change)
  • Remove unused base64 dependency and move hex to dev-dependencies (should have been done in Switch to serde-encoded-bytes #153)
  • Remove the need for getrandom/js dependency (crypto-primes's default features were requiring it, but we don't need those features)
  • Remove an explicit Debug for SecretKeyPaillier - derivation works well enough
  • Remove unncecessary Zeroize and ZeroizeOnDrop derivations (don't need Zeroize if ZeroizeOnDrop is already derived, and don't need ZeroizeOnDrop in structs that already have all secret data in SecretBox)

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (6bac5fa) to head (00ebe53).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
synedrion/src/paillier/keys.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   93.13%   93.14%   +0.01%     
==========================================
  Files          43       43              
  Lines        8124     8130       +6     
==========================================
+ Hits         7566     7573       +7     
+ Misses        558      557       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri marked this pull request as ready for review October 20, 2024 16:36
@fjarri fjarri merged commit b4ce49c into entropyxyz:master Oct 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
@fjarri fjarri deleted the assorted-fixes branch October 20, 2024 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant