Return of from_session_value

[nnakagaki]

In the rails 3.1 version, should from_session_value return
new(flashes, discard)
instead of
new(flashes, flashes.keys)

flashes seem to be getting discarded too quickly in the test environment. Works fine in others.

[sj26]

I'm pretty sure that logic is correct - we are only marking them for discard when the flash is next serialized, not discarding them at that point - and that is verified by the spec. Instead perhaps the version selection mechanism isn't working as expected?

[nnakagaki]

Hey so the problem was in ActionPack-3.0.19::ActionController::TestCase. In the gemfile line 408, @request.session["flash"].sweep

Solutions I thought of are were overwriting the sweep method so that it does nothing, or to monkeypatch TestCase to not have that one line, and that fixes the issue in the test.