Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm module signature verification #17220

Open
asraa opened this issue Jul 2, 2021 · 5 comments
Open

Wasm module signature verification #17220

asraa opened this issue Jul 2, 2021 · 5 comments
Labels
area/security area/wasm enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@asraa
Copy link
Contributor

asraa commented Jul 2, 2021

Title: Wasm module signature verification

Description:
Add the ability to configure verification options to satisfy before executing a Wasm module. This could include checking all/some/at least one signature is present from a list of specified verification keys in the Wasm bytecode according to https://github.com/jedisct1/wasmsign. I propose some kind of VerificationOption struct that contains

  • repeated public keys
  • verification type (at least 'n', ALL)
  • signature type (maybe reference to wasmsign)

If this is something interesting/use-able to others, I am happy to continue implementation.

Relevant Links
Draft PR here: #17221
The change depends on a PR in proxy-wasm-cpp-host: proxy-wasm/proxy-wasm-cpp-host#177

@asraa asraa added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jul 2, 2021
@asraa asraa added area/security area/wasm and removed triage Issue requires triage labels Jul 2, 2021
@asraa
Copy link
Contributor Author

asraa commented Jul 16, 2021

@PiotrSikora

@asraa
Copy link
Contributor Author

asraa commented Jul 30, 2021

Just a quick bump on this:
The draft PR only specifies a single public key for verification, and I'd expect that instead, some VerificationOption message should encapsulate that (e.g. with repeated public keys, options for the number of signatures expected).
WDYT?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 29, 2021
@mathetake mathetake removed the stale stalebot believes this issue/PR has not been touched recently label Aug 29, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 29, 2021
@mathetake mathetake removed the stale stalebot believes this issue/PR has not been touched recently label Sep 29, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 29, 2021
@Shikugawa Shikugawa added help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security area/wasm enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

3 participants