Use the do_ci.sh script for refreshing the compilation database
#37668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Karimi <[email protected]>
Signed-off-by: Ahmad Karimi <[email protected]>
|
/assign @phlax |
|
im gonna hand this over to @wbpcode as he has more context here (and cant test etc) |
wbpcode
reviewed
Dec 17, 2024
|
/wait |
Signed-off-by: Ahmad Karimi <[email protected]>
|
The change should be applied anywhere we call the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: use do_ci.sh for refreshing the compilation db
Additional Description:
Details are explained in this Github comment.
When refreshing the compilation database, the
proto_format.shandgen_compilation_database.pyscripts require the--config=clangand--config=libc++flags. Thedo_ci.shscript provides arefresh_compdbsubcommand that automatically includes these flags.This PR modifies the
.vscode/tasks.jsonfile to useci/do_ci.sh refresh_compdbinstead ofrefresh_compdb.shto refresh the compilation database used by VSCode.Risk Level: Low