From ccd4f7557b714b4a9b1273551bdf6f4175c119f5 Mon Sep 17 00:00:00 2001 From: "anurag.ag" Date: Wed, 2 Jul 2025 02:33:16 +0530 Subject: [PATCH 1/4] Adds slow start config to wrr proto message Signed-off-by: anurag.ag --- .../v3/client_side_weighted_round_robin.proto | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto index f913cb6a257b2..9e32f6ae173b2 100644 --- a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto +++ b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto @@ -2,6 +2,8 @@ syntax = "proto3"; package envoy.extensions.load_balancing_policies.client_side_weighted_round_robin.v3; +import "envoy/extensions/load_balancing_policies/common/v3/common.proto"; + import "google/protobuf/duration.proto"; import "google/protobuf/wrappers.proto"; @@ -82,4 +84,8 @@ message ClientSideWeightedRoundRobin { // For map fields in the ORCA proto, the string will be of the form ``.``. For example, the string ``named_metrics.foo`` will mean to look for the key ``foo`` in the ORCA :ref:`named_metrics ` field. // If none of the specified metrics are present in the load report, then :ref:`cpu_utilization ` is used instead. repeated string metric_names_for_computing_utilization = 7; + + // Configuration for slow start mode. + // If this configuration is not set, slow start will not be not enabled. + common.v3.SlowStartConfig slow_start_config = 8; } From cf7f22a6aace9219fe5781a88b208f29934741f5 Mon Sep 17 00:00:00 2001 From: "anurag.ag" Date: Wed, 2 Jul 2025 02:52:55 +0530 Subject: [PATCH 2/4] Adds commons dependency to BUILD Signed-off-by: anurag.ag --- .../client_side_weighted_round_robin/v3/BUILD | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD index 29ebf0741406e..2c85b121e2c93 100644 --- a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD +++ b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD @@ -5,5 +5,8 @@ load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") licenses(["notice"]) # Apache 2 api_proto_package( - deps = ["@com_github_cncf_xds//udpa/annotations:pkg"], + deps = [ + "//envoy/extensions/load_balancing_policies/common/v3:pkg", + "@com_github_cncf_xds//udpa/annotations:pkg", + ] ) From a842318cb7ed5bff5b52f86db6ebe59d256d1e28 Mon Sep 17 00:00:00 2001 From: "anurag.ag" Date: Wed, 2 Jul 2025 03:57:40 +0530 Subject: [PATCH 3/4] Fixes prechecks Signed-off-by: anurag.ag --- .../client_side_weighted_round_robin/v3/BUILD | 2 +- .../v3/client_side_weighted_round_robin.proto | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD index 2c85b121e2c93..3ff3820af87eb 100644 --- a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD +++ b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/BUILD @@ -8,5 +8,5 @@ api_proto_package( deps = [ "//envoy/extensions/load_balancing_policies/common/v3:pkg", "@com_github_cncf_xds//udpa/annotations:pkg", - ] + ], ) diff --git a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto index 9e32f6ae173b2..c55d30b89e059 100644 --- a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto +++ b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto @@ -44,7 +44,7 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE; // See the :ref:`load balancing architecture // overview` for more information. // -// [#next-free-field: 8] +// [#next-free-field: 9] message ClientSideWeightedRoundRobin { // Whether to enable out-of-band utilization reporting collection from // the endpoints. By default, per-request utilization reporting is used. From 464320b866ca5d2fddaa609a62d77d7d12f0f078 Mon Sep 17 00:00:00 2001 From: "anurag.ag" Date: Wed, 2 Jul 2025 14:38:20 +0530 Subject: [PATCH 4/4] Adds unimplemented for slow_start_config Signed-off-by: anurag.ag --- .../v3/client_side_weighted_round_robin.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto index c55d30b89e059..abaaf4ea82830 100644 --- a/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto +++ b/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto @@ -87,5 +87,6 @@ message ClientSideWeightedRoundRobin { // Configuration for slow start mode. // If this configuration is not set, slow start will not be not enabled. + // [#not-implemented-hide:] common.v3.SlowStartConfig slow_start_config = 8; }