provider: EG should not provision if parametersRef not found

[zirain]

fixes: #5080

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.97%. Comparing base (c499b41) to head (ffa227f).

Files with missing lines	Patch %	Lines
internal/provider/kubernetes/controller.go	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5081      +/-   ##
==========================================
+ Coverage   66.84%   66.97%   +0.12%     
==========================================
  Files         211      211              
  Lines       32920    32906      -14     
==========================================
+ Hits        22007    22039      +32     
+ Misses       9586     9545      -41     
+ Partials     1327     1322       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zirain]

You should not care whether the resource exists when deleting.

[arkodg]

was this a bug, uncovered while testing this change ?

[zirain]

apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: eg
spec:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
  parametersRef:
    group: gateway.envoyproxy.io
    kind: EnvoyProxy
    name: eg-daemonset
    namespace: default
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: eg-daemonset
  namespace: default
spec:
  gatewayClassName: eg
  listeners:
    - name: http
      port: 80
      protocol: HTTP
      allowedRoutes:
        namespaces:
          from: All
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: eg-daemonset
  namespace: default
spec:
  ipFamily: IPv4
  telemetry:
    accessLog:
      settings:
        - format:
            type: Text
            text: |
              [%START_TIME%] %METADATA(ROUTE:envoy-gateway:resources)% "%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%" %RESPONSE_CODE% %RESPONSE_FLAGS% %BYTES_RECEIVED% %BYTES_SENT% %DURATION% "%REQ(X-FORWARDED-FOR)%" "%REQ(USER-AGENT)%" "%REQ(X-REQUEST-ID)%" "%REQ(:AUTHORITY)%" "%UPSTREAM_HOST%"
          matches:
            - "'x-envoy-logged' in request.headers"
          sinks:
            - type: OpenTelemetry
              openTelemetry:
                backendRefs:
                  - name: otel-collector
                    namespace: monitoring
                    port: 4317
                resources:
                  k8s.cluster.name: "envoy-gateway"
  provider:
    type: Kubernetes
    kubernetes:
      envoyDaemonSet:
        patch:
          type: StrategicMerge
          value:
            spec:
              template:
                spec:
                  containers:
                    - name: envoy
                      readinessProbe:
                        initialDelaySeconds: 5
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: foo-route
  namespace: default
spec:
  parentRefs:
    - name: eg-daemonset
  rules:
    - backendRefs:
        - name: infra-backend-v1
          port: 8080
      matches:
        - path:
            type: PathPrefix
            value: /foo

with this demo, ds won't be removed.

[zirain]

GC(envoy-gateway) refernece EnvoyProxy(proxy-config), that make service monitoring/otel-collector is required.

[arkodg]

is this because we are using the same GC for conformance and e2e ? should we maintain 2 different GatewayClasses to keep each test suite more lightweight ?

[zirain]

yes, we can do that later.

[arkodg]

curious why this was removed

[zirain]

I think we should respect the logic in controller.go.

[zirain]

this made gateway always accepted, even the ref EnvoyProxy is not found.

[zirain]

this's not working for a long time and should blocked gateway provision.