From 458132bbffba303d88ad8e378549c550f0a7764a Mon Sep 17 00:00:00 2001 From: Idan Gadot Date: Fri, 26 Sep 2025 11:22:10 -0700 Subject: [PATCH 1/2] Update error message for unknown extension category Signed-off-by: Idan Gadot --- envoy.code.check/envoy/code/check/abstract/extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/envoy.code.check/envoy/code/check/abstract/extensions.py b/envoy.code.check/envoy/code/check/abstract/extensions.py index d186c0559..ebd827ade 100644 --- a/envoy.code.check/envoy/code/check/abstract/extensions.py +++ b/envoy.code.check/envoy/code/check/abstract/extensions.py @@ -324,7 +324,7 @@ async def _check_metadata_categories( "and category is set", ) return tuple( (f"Unknown extension category for {extension}: {cat}. " - "Please add it to tools/extensions/extensions_check.py") + "Please add it to {EXTENSIONS_SCHEMA}") for cat in categories if cat not in self.extension_categories) From 05c73e18b5782b13f29f415ea995dea0cad686b1 Mon Sep 17 00:00:00 2001 From: Idan Gadot Date: Fri, 26 Sep 2025 11:24:11 -0700 Subject: [PATCH 2/2] Update test Signed-off-by: Idan Gadot --- envoy.code.check/tests/test_abstract_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/envoy.code.check/tests/test_abstract_extensions.py b/envoy.code.check/tests/test_abstract_extensions.py index 0851e8fb6..b8fee7684 100644 --- a/envoy.code.check/tests/test_abstract_extensions.py +++ b/envoy.code.check/tests/test_abstract_extensions.py @@ -1066,7 +1066,7 @@ async def test_extensions__check_metadata_categories( if wrong_cats: expected = tuple( f"Unknown extension category for EXTENSION: {cat}. " - "Please add it to tools/extensions/extensions_check.py" + "Please add it to tools/extensions/extensions_schema.yaml" for cat in wrong_cats) else: