Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic icon doesn't quite respect shell light style #308

Closed
not-a-dev-stein opened this issue Dec 1, 2023 · 4 comments
Closed

Symbolic icon doesn't quite respect shell light style #308

not-a-dev-stein opened this issue Dec 1, 2023 · 4 comments
Labels

Comments

@not-a-dev-stein
Copy link

A small change in GNOME 45 that almost went unnoticed due to not being exposed outside of gsettings yet is the shell light style. One can use it by enabling it through gsettings or by using the Light Style extension, and when you are using it, the caffeine icon doesn't quite work with it. An example of how it looks follows:

image

See how the cup icon works well but the "vapor" part of the icon doesn't recolor? That's the thing. It's not a major issue, but it's something that bugs me and that should probably be fixed before GNOME 46, where it'll likely be exposed in the settings.

@stuarthayhurst
Copy link
Collaborator

Thanks for catching this, can you test #309 please?

@not-a-dev-stein
Copy link
Author

Oh shoot, didn't catch that open MR, it works great!

@stuarthayhurst
Copy link
Collaborator

Oh shoot, didn't catch that open MR, it works great!

Glad it works! You didn't miss it, I submitted it in response to this report :)

stuarthayhurst added a commit that referenced this issue Dec 1, 2023
Fix steam on symbolic icon not respecting shell style (fixes #308)
@not-a-dev-stein
Copy link
Author

Oh shoot, didn't catch that open MR, it works great!

Glad it works! You didn't miss it, I submitted it in response to this report :)

Wow, thanks for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants