Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): apply new format to card component #977

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

hanakoori01
Copy link
Contributor

@hanakoori01 hanakoori01 commented Sep 12, 2022

What does this PR do?

Steps to test

  1. Run make run
  2. Go to localhost:3000
  3. Go to Proxies
  4. Go to homepage

Copy link
Member

@tetogomez tetogomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comments

const handleTooltip = e => {
setOpen(!open)
e.preventDefault()
}
console.log(data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, delete this console.log

transparency: data.total_transparency,
trustiness: data.total_trustiness
})
// ...data.data,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Copy link
Member

@tetogomez tetogomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tetogomez tetogomez merged commit bbf601c into eoscostarica:staging Sep 12, 2022
xavier506 added a commit that referenced this pull request Sep 14, 2022
* fix(webapp): apply new format to card component

* fix(webapp): code review remove unused code

Co-authored-by: Paola Espinoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bugs on EOS Rate Proxies not showing data No Ratings data on homepage BPs
2 participants