feat(docs): react new section #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edgar097
requested review from
xavier506,
tetogomez,
leisterfrancisco,
ldrojas and
steph222
steph222
reviewed
Jan 27, 2021
steph222
reviewed
Jan 27, 2021
leisterfrancisco
requested changes
Jan 27, 2021
|
Thanks for the feedback @leisterfrancisco @steph222 |
xavier506
reviewed
Jan 27, 2021
xavier506
reviewed
Jan 27, 2021
tetogomez
reviewed
Jan 27, 2021
| import logo from './logo.svg'; | ||
| import './App.css'; | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
Use Arrow function instead regular function
There was a problem hiding this comment.
In this case i dont want to change this code because is a copy-paste default code generated by React JS new proyect, so it can be exactly the same for the tutorial purpose
leisterfrancisco
requested changes
Jan 27, 2021
|
Thank you for the feedback everyone! Here is another version with all the notes that you all gave me. |
steph222
reviewed
Feb 1, 2021
steph222
reviewed
Feb 1, 2021
tetogomez
previously approved these changes
Feb 1, 2021
| import logo from './logo.svg'; | ||
| import './App.css'; | ||
|
|
||
| function App() { |
|
Check de comments BTW: nice job @Edgar097 |
steph222
reviewed
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Issue
Resolves #183
Steps to test
CheckList