Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CMake Dependency Issues #333

Open
kj4ezj opened this issue Feb 22, 2023 · 1 comment
Open

Resolve CMake Dependency Issues #333

kj4ezj opened this issue Feb 22, 2023 · 1 comment
Labels
bug Something isn't working design DevOps Unify development and operations practices to shorten systems engineering lifecycles invalid This doesn't seem right
Milestone

Comments

@kj4ezj
Copy link
Contributor

kj4ezj commented Feb 22, 2023

From issue 242, I found the cmake command performs dependency builds that:

  • Leave files outside the build/repo folder, such as ~/.hunter, which impact future builds.
  • Takes >10 minutes on an enf-x86-beefy runner, which uses an n2d-standard-224 GCP instance type with 224 cores and >768 GB RAM.
  • Takes >50 minutes on an enf-x86-lowtier runner, which uses an e2-custom-8-16384 instance type.
  • Takes ~88 minutes on a free GitHub Actions Ubuntu runner.

This is frankly absurd. Are we building Linux from scratch, and then using it to build all dependencies and the operating system? None of our other ENF or AntelopeIO products take more than ~10 seconds to generate make files, none of them install dependencies to the user's system outside of the build or repo folder without consent, none of them perform git clones, and none of them perform make builds. The fact that an n2d-standard-224 could not complete the entire TrustEVM node build within ten minutes suggests there is a fundamental issue with this project architecture.

Acceptance Criteria

  • The cmake command completes in 60 seconds or less on any and all of these three runners:
    1. enf-x86-beefy using an n2d-standard-224 GCP instance type.
    2. enf-x86-lowtier using an e2-custom-8-16384 instance type.
    3. Free GitHub Actions Ubuntu runner.
  • The cmake command does not result in files being left outside of the current directory, subdirectories of the current directory, or the git repo directory.
    • The cmake command does not result in dependencies being installed to the user's system.
@kj4ezj kj4ezj added bug Something isn't working invalid This doesn't seem right design DevOps Unify development and operations practices to shorten systems engineering lifecycles labels Feb 22, 2023
@arhag arhag added this to the Post-launch milestone Apr 5, 2023
@cc32d9
Copy link

cc32d9 commented May 8, 2023

just bumped into that, and it's only using one CPU core. Still waiting for it to finish. Also, it took over 1.5GB of space in ~/.hunter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design DevOps Unify development and operations practices to shorten systems engineering lifecycles invalid This doesn't seem right
Projects
Status: Todo
Development

No branches or pull requests

3 participants