Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test framework for node and rpc #554

Closed
yarkinwho opened this issue May 24, 2023 · 1 comment
Closed

Fix unit test framework for node and rpc #554

yarkinwho opened this issue May 24, 2023 · 1 comment
Assignees
@elmato
Labels
CICD Continuous integration, continuous deployment - build and test system 👍 lgtm
Milestone
0.6.0 preliminary

Comments

@yarkinwho
Copy link
Contributor

yarkinwho commented May 24, 2023 •
edited by arhag
Loading

The old test framework from silkworm seems broken, we need fix that to better guard the code.

Depends on #589.
@github-project-automation github-project-automation bot moved this to Todo in EOS EVM May 24, 2023
@yarkinwho yarkinwho added CICD Continuous integration, continuous deployment - build and test system 👍 lgtm labels May 24, 2023
@yarkinwho yarkinwho added this to the 0.6.0 milestone May 24, 2023
@yarkinwho yarkinwho mentioned this issue May 24, 2023
Closed
@arhag arhag moved this from Todo to In Progress in EOS EVM Jun 7, 2023
@taokayan taokayan mentioned this issue Jun 7, 2023
Closed
@arhag arhag linked a pull request Jun 14, 2023 that will close this issue
fix unittests #576
Closed
@Joshua2Mars Joshua2Mars moved this from In Progress to Done in EOS EVM Jul 6, 2023
@elmato
Copy link
Contributor

elmato commented Jul 6, 2023

Test are fixed (only one failing, empty tx serialization) after this commit
eosnetworkfoundation/silkworm@efb5a23

@elmato elmato closed this as completed Jul 6, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Jul 6, 2023
@stephenpdeos stephenpdeos mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elmato elmato

Labels
CICD Continuous integration, continuous deployment - build and test system 👍 lgtm
Projects
EOS EVM
Status: Done
Milestone
0.6.0 preliminary
Development

Successfully merging a pull request may close this issue.

fix unittests eosnetworkfoundation/eos-evm-contract
3 participants
@elmato @taokayan @yarkinwho