Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how the miner portion of the gas fee is calculated #696

Closed
Tracked by #198
elmato opened this issue Apr 3, 2024 · 0 comments · Fixed by #704
Closed
Tracked by #198

Change how the miner portion of the gas fee is calculated #696

elmato opened this issue Apr 3, 2024 · 0 comments · Fixed by #704
Assignees

Comments

@elmato
Copy link
Contributor

elmato commented Apr 3, 2024

Depends on eosnetworkfoundation/silkworm#138 and #697

Update the silworm submodule to contain changes from eosnetworkfoundation/silkworm#138.

When eos_evm_version >= 1, the gas_fee_miner_portion should be calculated using the priority_fee_per_gas and the receipt.cumulative_gas_used.

At this point the miner_cut is no longer used. update_gas_parameters should be updated to no longer depend on miner_cut when eos_evm_version >= 1. In that case, it can assume that the gas price provided to can be interpreted as the base gas price (effectively acting like the miner_cut is 0).

We should also disallow any further changes to miner_cut after eos_evm_version >= 1. Also, when upgrade to eos_evm_version from 0 to a number greater than or equal to 1, we should change the miner_cut in the config to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants