Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing hunter build and few c++ errors #549

Closed
wants to merge 1 commit into from
Closed

fixing hunter build and few c++ errors #549

wants to merge 1 commit into from

Conversation

dimas1185
Copy link

fixes #548

@spoonincode spoonincode removed their request for review June 8, 2023 21:14
@stephenpdeos stephenpdeos requested a review from elmato June 9, 2023 00:36
@elmato
Copy link
Contributor

elmato commented Jun 20, 2023

Hi @dimas1185, we are currently updating silkworm to the latest version and they have made changes to the build system.

This is a WIP of silkworm update:
https://github.com/eosnetworkfoundation/silkworm/commits/elmato/new-silkworm

Can you check if you have problems building this branch?

@dimas1185
Copy link
Author

@elmato I can't build with this one, it would require different changes. the first issue I see is this file is missing:
include(${CMAKE_SOURCE_DIR}/silkworm/cmake/Hunter/config.cmake)

@yarkinwho
Copy link
Contributor

Now hunter is no longer used in build.

We can close the issue.

@elmato
Copy link
Contributor

elmato commented Aug 29, 2023

Fixed in #628

@elmato elmato closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build with Ubuntu 22.10 and gcc 12.2.0
3 participants