Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos-evm-rpc crash: Assert failed: max_fee_per_gas >= base_fee_per_gas #260

Closed
stephenpdeos opened this issue Jul 23, 2024 · 2 comments · Fixed by #280 or #281
Closed

eos-evm-rpc crash: Assert failed: max_fee_per_gas >= base_fee_per_gas #260

stephenpdeos opened this issue Jul 23, 2024 · 2 comments · Fixed by #280 or #281
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@stephenpdeos
Copy link
Member

No description provided.

@stephenpdeos stephenpdeos converted this from a draft issue Jul 23, 2024
@stephenpdeos stephenpdeos added bug Something isn't working 👍 lgtm labels Jul 23, 2024
@stephenpdeos stephenpdeos added this to the EVM Node 1.0.0-rc5 milestone Jul 23, 2024
@taokayan
Copy link
Contributor

taokayan commented Aug 1, 2024

Seems this assert failed will be triggered in the following scenario:

  • update gas price from 150Gwei to 300Gwei
  • the new gas price is somewhat in the queue and will be activated in some time T1 in the future
  • wait after T1
  • the miner can't get the new price 300Gwei, so it still returns 150Gwei to metamask
  • metamask send transaction with gas price = 150Gwei then hit this assertion: assertion failure with message: pre_validate_transaction error: 25 Max fee per gas less than block base fee

Also i am no longer able to re-produce the crash.

./cleos get table eosio.evm eosio.evm config
{
  "rows": [{
      "version": 0,
      "chainid": 15557,
      "genesis_time": "2024-08-01T07:41:52",
      "ingress_bridge_fee": "0.0100 EOS",
      "gas_price": "150000000000",
      "miner_cut": 0,
      "status": 0,
      "evm_version": {
        "pending_version": null,
        "cached_version": 2
      },
      "consensus_parameter": {
        "current": [
          "consensus_parameter_data_v0",
            "gas_parameter": {
              "gas_txnewaccount": 1129832,
              "gas_newaccount": 1129832,
              "gas_txcreate": 1973136,
              "gas_codedeposit": 3256,
              "gas_sset": 1129476
            }
          }
        ],
        "pending": null
      },
      "token_contract": "eosio.token",
      "queue_front_block": 786
    }
  ],

  "more": false,

  "next_key": ""

@stephenpdeos
Copy link
Member Author

Because this is not reproduceable, we are closing

@stephenpdeos stephenpdeos closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@elmato elmato reopened this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in EOS EVM Aug 21, 2024
@elmato elmato linked a pull request Aug 21, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in EOS EVM Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Status: Done
3 participants