eos-evm-node repo integration test #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use eos-evm repo contract artifact.
Trying to manually solve error installing leap deb package around unmet dependencies.
Set up absolute paths as workflow step outputs to be reused in test invokation.
Having tests and peripherals in the build allows simply downloading the archived build artifact and having everything necessary to run integration tests. Update node.yaml workflow for using only the build artifact. It no longer needs to clone the eos-evm-node repository.
…nch an eos-evm-rpc. Also add error checking for the eos-evm-rpc logs and killing of the process at end of test.
heifner
requested changes
Aug 2, 2023
| run: | | ||
| mkdir test_run_root | ||
| cd test_run_root | ||
| ${{ steps.evm-node-build.outputs.EVM_NODE_BUILD }}/tests/nodeos_eos_evm_test.py -v --eos-evm-contract-root ${{ steps.evm-contract.outputs.EVM_CONTRACT }} --eos-evm-build-root ${{ steps.evm-node-build.outputs.EVM_NODE_BUILD }} --use-tx-wrapper ${{ steps.evm-node-build.outputs.EVM_NODE_BUILD }}/peripherals/tx_wrapper |
There was a problem hiding this comment.
Should we consider setting up ctest?
There was a problem hiding this comment.
I'm not sure what that would look like since this is an integration test that requires access to leap, leap-dev, cdt, eos-evm-contract which may not be available locally for ctest.
elmato
reviewed
Aug 2, 2023
Seems this change is still necessary. This reverts commit 51c323c.
heifner
approved these changes
Aug 2, 2023
elmato
approved these changes
Aug 2, 2023
require is not defined in ES module scope, you should use import instead.
Update package-lock.json and yarn.lock
ericpassmore
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #11
Port PR for leap integration test updates and workflow. (eosnetworkfoundation/eos-evm-contract#355)
Use
eos-evmrepo forcontractartifact.leap,leap-dev,cdt,eos-evm-contractbuild.tar.gzby omitting object files from uploaded artifact.nodeos_eos_evm_test.pyto work with changes made when porting code over toeos-evm-nodeand splitting outeos-evm-rpcinto separate executable.nodeos_eos_evm_test.pyeos-evm-nodebuild, addstestsandperipheralsto build dir to be included in tarball artifact of build, and copies executables into thebindirectory.tx_wrapper/index.js