Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertnonce whenever doing a contract deployment #8

Closed
Tracked by #193
stephenpdeos opened this issue Aug 30, 2023 · 0 comments · Fixed by #5
Closed
Tracked by #193

Use assertnonce whenever doing a contract deployment #8

stephenpdeos opened this issue Aug 30, 2023 · 0 comments · Fixed by #5
Assignees

Comments

@stephenpdeos
Copy link
Member

stephenpdeos commented Aug 30, 2023

Dependent on eosnetworkfoundation/eos-evm-contract#645 and eosnetworkfoundation/eos-evm-contract#612

Places in the code where a nonce is needed to calculate the contract address, the nonce value is retrieved from the internal tables of the eos evm contract. As extra precaution, we should assert that the retrieved nonce is correct by sending an inline assertnonce action to the eos evm contract with the retrieved value of the nonce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants