Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same code for writing blocks and ship logs #113

Open
cc32d9 opened this issue Apr 19, 2022 · 1 comment
Open

Same code for writing blocks and ship logs #113

cc32d9 opened this issue Apr 19, 2022 · 1 comment
Labels
3.2 Candidate tech debt

Comments

@cc32d9
Copy link
Contributor

cc32d9 commented Apr 19, 2022

At the moment blocks log and state history logs are written by separate pieces of code, although their internal structures are similar.

If these would be handled by one code components, it would reduce the code duplication, and let log rotation to be implemented in once place.
@matthewdarwin matthewdarwin added the enhancement New feature or request label Apr 19, 2022
@spoonincode spoonincode removed their assignment Jun 16, 2022
@stephenpdeos stephenpdeos added tech debt and removed enhancement New feature or request labels Aug 4, 2022
@stephenpdeos stephenpdeos changed the title Enhancement: same code for writing blocks and ship logs Same code for writing blocks and ship logs Aug 4, 2022
@stephenpdeos
Copy link
Member

To be evaluated when we seek to refactor block log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.2 Candidate tech debt
Projects
ENF Engineering
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@matthewdarwin @spoonincode @cc32d9 @tedcahalleos @stephenpdeos