Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last_code_update in get_code_hash API #762

Open
jafri opened this issue Jul 17, 2022 · 3 comments
Open

last_code_update in get_code_hash API #762

jafri opened this issue Jul 17, 2022 · 3 comments
Labels
CONSENSUS Changes the core protocol planning Propose change to milestone in next planning meeting

Comments

@jafri
Copy link
Contributor

jafri commented Jul 17, 2022

get_code_hash has code_sequence, vm_type, vm_version, etc from the code db but it specifically omits last_code_update, what is the rationale here? Knowing the last code update time is useful.
@heifner heifner added the planning Propose change to milestone in next planning meeting label Jul 18, 2022
@stephenpdeos stephenpdeos added the CONSENSUS Changes the core protocol label Jul 28, 2022
@stephenpdeos
Copy link
Member

@jafri can you elaborate on the problems solved here? Working for future prioritization of this request. Thanks!

@jafri
Copy link
Contributor Author

jafri commented Jul 28, 2022

last_code_update shows what time the code was last updated at, useful for putting limits on code update time frames

@swatanabe
Copy link
Contributor

Note that last_code_update is not currently part of consensus state.

@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CONSENSUS Changes the core protocol planning Propose change to milestone in next planning meeting
Projects
ENF Engineering
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@swatanabe @heifner @jafri @stephenpdeos