Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gemini: improve error messages and PDF validation #187

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

adubovik
Copy link
Collaborator

@adubovik adubovik commented Feb 13, 2025

Fixed the following issues:

  1. Validation errors for attachments were shadowed by a generic failed to download attachment error message.
  2. The limits for the number of PDF pages were out-dated: it should 3000 for the request, and 1000 for a document.
Screenshot 2025-02-13 at 16 31 47

@adubovik adubovik self-assigned this Feb 13, 2025
@adubovik
Copy link
Collaborator Author

adubovik commented Feb 13, 2025

/deploy-review

Environment URL: https://chat-ai-dial-adapter-vertexai-pr-187.nightly-test.deltixhub.io
E2E tests status: failed

@adubovik adubovik changed the title fix: gemini: improve error messages fix: gemini: improve error messages and PDF validation Feb 13, 2025
@adubovik
Copy link
Collaborator Author

adubovik commented Feb 13, 2025

/deploy-review

Environment URL: https://chat-ai-dial-adapter-vertexai-pr-187.nightly-test.deltixhub.io
E2E tests status: failed

@adubovik
Copy link
Collaborator Author

adubovik commented Feb 13, 2025

/deploy-review

Environment URL: https://chat-ai-dial-adapter-vertexai-pr-187.nightly-test.deltixhub.io
E2E tests status: success

@adubovik adubovik merged commit 1b71f8e into development Feb 14, 2025
6 checks passed
@adubovik adubovik deleted the fix/gemini-improve-error-messages branch February 14, 2025 11:14
adubovik added a commit that referenced this pull request Feb 14, 2025
* feat: Add Gemini 2.0 Pro/Flash Lite (#185)

* chore: bump cryptography from 43.0.1 to 44.0.1 (#186)

* fix: gemini: improve error messages and document limits validation (#187)

* chore: empty commit to trigger CI

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants