Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to remove Copy, Like/Dislike buttons if there is error instead of valuable response #125

Closed
VolhaBazhkova opened this issue Nov 14, 2023 · 1 comment
Closed

Need to remove Copy, Like/Dislike buttons if there is error instead of valuable response #125

VolhaBazhkova opened this issue Nov 14, 2023 · 1 comment
Assignees
@Alexander-Kezik @VolhaBazhkova
Labels
enhancement New feature or request

Comments

@VolhaBazhkova
Copy link

VolhaBazhkova commented Nov 14, 2023 •
edited
Loading

image

November 13, 2024. Agreed on daily to do the following:

  1. If there is error only (or stage only + error) in the response Copy, Like an Dislike buttons should not be available
  2. If there is some text in the response + error in the response Copy, Like and Dislike buttons should be available

Be sure to make equal behaviour for laptop, mobile, tablet
@VolhaBazhkova VolhaBazhkova added the enhancement New feature or request label Nov 14, 2023
@avavilau avavilau added this to AI DIAL Nov 15, 2023
@Alexander-Kezik Alexander-Kezik self-assigned this Dec 23, 2024
@Alexander-Kezik Alexander-Kezik moved this to In Progress in AI DIAL Dec 23, 2024
Alexander-Kezik added a commit that referenced this issue Dec 23, 2024
@Alexander-Kezik
fix(chat): show like/dislike/copy buttons only if content message has…
990163f 
…n't error message or content isn't empty (Issue #125)
@Alexander-Kezik Alexander-Kezik mentioned this issue Dec 23, 2024
Merged
4 tasks
@Alexander-Kezik Alexander-Kezik moved this from In Progress to Code Review in AI DIAL Dec 23, 2024
@Alexander-Kezik Alexander-Kezik moved this from Code Review to In Progress in AI DIAL Dec 23, 2024
Alexander-Kezik added a commit that referenced this issue Dec 24, 2024
@Alexander-Kezik
fix(chat): show like/dislike/copy buttons only if content message has…
f41850e 
…n't error message or content isn't empty (Issue #125) (#2865)
@Alexander-Kezik Alexander-Kezik moved this from In Progress to In Testing in AI DIAL Dec 24, 2024
@Alexander-Kezik Alexander-Kezik moved this from In Testing to Code Review in AI DIAL Dec 24, 2024
Alexander-Kezik added a commit that referenced this issue Dec 24, 2024
@Alexander-Kezik
fix(chat): hide copy button if message hasn't content (Issue #125)
d4c7321
@Alexander-Kezik Alexander-Kezik mentioned this issue Dec 24, 2024
Merged
4 tasks
Alexander-Kezik added a commit that referenced this issue Dec 24, 2024
@Alexander-Kezik
fix(chat): hide copy button if message hasn't content (Issue #125) (#…
cea1900 
…2873)
@Alexander-Kezik Alexander-Kezik moved this from Code Review to In Testing in AI DIAL Dec 24, 2024
@VolhaBazhkova VolhaBazhkova self-assigned this Dec 27, 2024
@VolhaBazhkova
Copy link
Author

Verified on staging env successfully. Reported #2893, #2887, #2894, #1963

@github-project-automation github-project-automation bot moved this from In Testing to Done in AI DIAL Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexander-Kezik Alexander-Kezik

@VolhaBazhkova VolhaBazhkova

Labels
enhancement New feature or request
Projects
AI DIAL
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexander-Kezik @VolhaBazhkova